Harish-Research-Lab / Photo2CAD

Automated CAD model generator
GNU General Public License v3.0
38 stars 2 forks source link

Rounded Corners #1

Open ghost opened 3 years ago

ghost commented 3 years ago

First of all, congratulations, wonderful work.

I am not able to test one specific case right now and would like to ask you about it.

How would the program cope with a block with rounded outer corners?

From what I saw in the code, there is no hull support.

Will it currently detect the rounded corners as circles and combine all with union?

ghost commented 3 years ago

Update: I checked the code more thoroughly and found out. I believe support for polygon and ellipse would be pretty valuable.

Since they are standard openscad shapes, they should be trivial additions.

bhajay commented 3 years ago

Sorry for the delayed reply. Sure, I agree. I can surely add those.