Harithhh06 / pe

0 stars 0 forks source link

Duplicate member index for session #12

Open Harithhh06 opened 1 week ago

Harithhh06 commented 1 week ago

Screenshot 2024-11-15 at 4.59.52 PM.png

Description

adding a session and repeating a member still adds the session without warning of duplicate input. Can be troublesome if a user intends to add to 2 diff members but mistypes and there is no warning or indicator for the duplicate input. If the list is long and difficult to check, it will make tracking of sessions harder

eg. intended to type m/11 m/12 but typed m/11 m/11

Steps to Reproduce

add_session s/Rehearsal d/24 Oct 2024 p/2 m/1 m/1

Expected Outcome

Error or warning thrown

Actual Outcome

Session is still added without any warning output message

nus-se-bot commented 1 week ago

Team's Response

We will be arguing that the severity of this bug is low as this occurs from a typo on the user end which is uncommon. Moreover, the user can check the number of members added after the command is successful through the success message to verify that the correct number of members are added.

However, we do agree that a warning would be helpful for the user.

Items for the Tester to Verify

:question: Issue severity

Team chose [severity.Low] Originally [severity.Medium]

Reason for disagreement: [replace this with your explanation]