search

Harkishen-Singh / Jarvis-personal-assistant

Comfort of a personal assistant for Linux systems. Currently features native google, yahoo, bing searches, weather conditions, videos from youtube and looking up for images as well, all in a very reliable structure and UI.
45 stars 45 forks source link

Added yahoo scrapping with golang #197

Closed irshadjsr21 closed 4 years ago

irshadjsr21 commented 4 years ago

This PR solves issue #138

What does this PR do? Added yahoo scrapping with golang

Screenshots? Screenshot from 2020-03-16 03-15-46

irshadjsr21 commented 4 years ago

@muskankhedia The code is working, it is just that sometimes Yahoo server rejects the request. You can check the build log, it failed one time and ran for another.

prashant-mahanta commented 4 years ago

@irshadjsr21 can't we do something like requesting until we get results.

muskankhedia commented 4 years ago

@irshadjsr21 can't we do something like requesting until we get results.

Yaa.. for that reason only we use selenium or puppeteer, as these open a virtual browser and waits till the page has been loaded. But for now, we are planning to remove these kind of dependencies so as to avoid different circumstances while launching as well creating a single method to execute all the feature.

irshadjsr21 commented 4 years ago

@muskankhedia So what should I do now?

muskankhedia commented 4 years ago

@irshadjsr21 Let the implementation in Golang for now, will enhance it later.

Harkishen-Singh commented 4 years ago

@irshadjsr21 can you fix the Travis?

irshadjsr21 commented 4 years ago

@Harkishen-Singh The code runs on my system, I think it will work if we rebuild it.

C-Anirudh commented 4 years ago

@irshadjsr21 Please resolve the merge conflicts.

irshadjsr21 commented 4 years ago

@C-Anirudh The conflicts has been resolved,

muskankhedia commented 4 years ago

@irshadjsr21 The testing files have been updated presently. Can you pull the recent updates to test the PR?