HarlemSquirrel / gnome-shell-extension-sensory-perception

Displays CPU/GPU/mobo/disk temperatures, voltages and fan speeds
https://extensions.gnome.org/extension/1145/sensory-perception/
GNU General Public License v3.0
27 stars 11 forks source link

Not able to see settings for the extension #35

Open stardust-xs opened 3 years ago

stardust-xs commented 3 years ago

I just installed the extension and though of changing couple of things, but the extension popped up with a failure message.

To Reproduce Steps to reproduce the behavior:

  1. Go to the extension settings from Panel shortcut.

Here is the log:

The settings of extension sensory-perception@HarlemSquirrel.github.io had an error:

GLib.ShellError: Text was empty (or contained only whitespace)

Stack trace:

_getSensorsLabels@/home/xa/.local/share/gnome-shell/extensions/sensory-perception@HarlemSquirrel.github.io/prefs.js:200:40
_init@/home/xa/.local/share/gnome-shell/extensions/sensory-perception@HarlemSquirrel.github.io/prefs.js:149:14
buildPrefsWidget@/home/xa/.local/share/gnome-shell/extensions/sensory-perception@HarlemSquirrel.github.io/prefs.js:281:20
_init@resource:///org/gnome/Shell/Extensions/js/extensionsService.js:207:40
OpenExtensionPrefsAsync/<@resource:///org/gnome/Shell/Extensions/js/extensionsService.js:122:28
asyncCallback@resource:///org/gnome/gjs/modules/core/overrides/Gio.js:132:13
run@resource:///org/gnome/Shell/Extensions/js/dbusService.js:175:20
main@resource:///org/gnome/Shell/Extensions/js/main.js:19:13
run@resource:///org/gnome/gjs/modules/script/package.js:222:19
start@resource:///org/gnome/gjs/modules/script/package.js:206:5
@/usr/share/gnome-shell/org.gnome.Shell.Extensions:1:17
HarlemSquirrel commented 3 years ago

Could you please share the output of sensors command?

stardust-xs commented 3 years ago

The above is what I got when I clicked, let me know what else should I provide you in particular. If this seems to be an open/persistent issue then feel free to close it.

HarlemSquirrel commented 3 years ago

To help debug this, could you please run sensors in a terminal and share the output here? Thank you!

stardust-xs commented 3 years ago

Yes, I got this after running the said command,

$  sensors
ath10k_hwmon-pci-0200
Adapter: PCI adapter
temp1:        +38.0°C  

coretemp-isa-0000
Adapter: ISA adapter
Package id 0:  +57.0°C  (high = +100.0°C, crit = +100.0°C)
Core 0:        +50.0°C  (high = +100.0°C, crit = +100.0°C)
Core 1:        +57.0°C  (high = +100.0°C, crit = +100.0°C)
Core 2:        +56.0°C  (high = +100.0°C, crit = +100.0°C)
Core 3:        +50.0°C  (high = +100.0°C, crit = +100.0°C)

BAT1-acpi-0
Adapter: ACPI interface
in0:          16.61 V  
curr1:         0.00 A  

pch_skylake-virtual-0
Adapter: Virtual device
temp1:        +51.0°C  

nvme-pci-0400
Adapter: PCI adapter
Composite:    +44.9°C  (low  =  -5.2°C, high = +79.8°C)
                       (crit = +84.8°C)

acpitz-acpi-0
Adapter: ACPI interface
temp1:        +27.8°C  (crit = +119.0°C)
temp2:        +29.8°C  (crit = +119.0°C)
HarlemSquirrel commented 3 years ago

What version of GNOME are you on?

stardust-xs commented 3 years ago

GNOME version is 3.36.8

HarlemSquirrel commented 3 years ago

I'm a bit stumped on this one. Assuming you're on v13, the line in the backtrack is reading from sensors command and is reporting the output is blank/empty.

https://github.com/HarlemSquirrel/gnome-shell-extension-sensory-perception/blob/v13/prefs.js#L200

This usually happens if sensors is not installed. Could you try manually install v12 and see if you get the same issue?

HarlemSquirrel commented 3 years ago

@xames3 could you run this from a terminal and share the output?

gjs --command="var sensorsProg = imports.gi.GLib.find_program_in_path('sensors'); log('typeof: ' + (typeof sensorsProg)); log(sensorsProg);"
HarlemSquirrel commented 3 years ago

@xames3 @xzj8b3 Can you try running the code in the latest master and let me know if that works for you?

xzj8b3 commented 3 years ago

@ xames3 @ xzj8b3 Puoi provare a eseguire il codice nell'ultimo master e fammi sapere se funziona per te?

Sorry delay, now it seems to be working but not showing fan speeds or anything.

I'm on Gnome 40 with Fedora 34

HarlemSquirrel commented 3 years ago

Can you share the output of sensors from your terminal?

timur-tabi commented 2 years ago

I was getting this problem and then I installed lm-sensors and now it works. It would be handy if the extension could detect that lm-sensors is not installed instead of just crashing.

HarlemSquirrel commented 2 years ago

@timur-tabi That's what I attempted to do in the last code but it's not released yet. Can you confirm that the code from the latest master branch allows you to load the preferences when lm-sensors is not installed?

HarlemSquirrel commented 2 years ago

There's a new release out for GNOME 40 and 41 that should better handle missing sensors program.

Tyrben commented 1 year ago

Gnome 3.38 Debian 11 lm-sensors NOT installed

GLib.ShellError: Le texte était vide (ou ne contenait que des espaces) Stack trace: _getSensorsLabels@/home/---/.local/share/gnome-shell/extensions/sensory-perception@HarlemSquirrel.github.io/prefs.js:200:40 _init@/home/---/.local/share/gnome-shell/extensions/sensory-perception@HarlemSquirrel.github.io/prefs.js:149:14 buildPrefsWidget@/home/---/.local/share/gnome-shell/extensions/sensory-perception@HarlemSquirrel.github.io/prefs.js:281:20 _init@resource:///org/gnome/Shell/Extensions/js/extensionsService.js:207:40 OpenExtensionPrefsAsync/<@resource:///org/gnome/Shell/Extensions/js/extensionsService.js:122:28 asyncCallback@resource:///org/gnome/gjs/modules/core/overrides/Gio.js:132:22 run@resource:///org/gnome/Shell/Extensions/js/dbusService.js:177:20 main@resource:///org/gnome/Shell/Extensions/js/main.js:19:13 run@resource:///org/gnome/gjs/modules/script/package.js:222:19 start@resource:///org/gnome/gjs/modules/script/package.js:206:8 @/usr/share/gnome-shell/org.gnome.Shell.Extensions:1:17

(+) a s2t tone of systemctl log

mars 11 20:21:00 --- gnome-shell[1449]: sensory-perception@HarlemSquirrel.github.io: ERROR Future _init: Error: Array element (type filename) may not be null

So I run your command:

gjs --command="var sensorsProg = imports.gi.GLib.find_program_in_path('sensors'); log('typeof: ' + (typeof sensorsProg)); log(sensorsProg);" Gjs-Message: 20:15:46.262: JS LOG: typeof: object Gjs-Message: 20:15:46.262: JS LOG: null

Some on internet mention this error when switching of js version.

HarlemSquirrel commented 1 year ago

You'll need to install lm-sensors