HarlemSquirrel / language-haml

Haml language grammar for GitHub's Atom IDE
MIT License
33 stars 24 forks source link

Fix patterns for matching embedded Ruby code #60

Closed Alhadis closed 7 years ago

Alhadis commented 7 years ago

This PR addresses an unusual and ugly recursion issue when highlighting certain Haml files on GitHub. See github/linguist#3627 for details.

vmg commented 7 years ago

Thank you for this fix, @Alhadis!

@ezekg: We use this grammar to highlight all HAML code on GitHub. We'd appreciate it if you could merge the fix so that we can keep using it. :)

ezekg commented 7 years ago

This looks awesome! I've been meaning to fix this up for awhile now. Thanks. 🙌

ezekg commented 7 years ago

Tagged and published v0.24.2.

Alhadis commented 7 years ago

Excellent, thank you for the quick response!

@vmg I'll leave it to you to revert the, erm, reversion. Don't want to get underfoot. =)