Detect composer installation failure

Harmonic / laravel-preset

Laravel preset with inertiaJS, Tailwind CSS and admin theme.

42 stars 4 forks source link

Closed atymic closed 4 years ago

atymic commented 4 years ago

Using this on another project :D Using my PR for l6, #2 but I think this applies anyway.

If composer install fails, the installer continues, but the app is left in a broken state.

We should instead catch the failure exit code, and present the error to fix to the user.

Happy to PR :)

craigharman commented 4 years ago

Agreed, would love to see a PR for this @atymic Thanks.

atymic commented 4 years ago

I've created a PR with that and a bunch of other improvements :)