search

Harmonic / vue-tailwind-modal

A modal box made for Vue that uses Tailwind CSS
28 stars 7 forks source link

Strange states #32

Open lonagi opened 3 years ago

lonagi commented 3 years ago

Why do I need the showClose state (for X) if I want just to close modal using escape or click to bg?

image

wut ?

image

lonagi commented 3 years ago

Sorry for closing.

What's solution for this issue. Just delete if states

craigharman commented 3 years ago

showClose currently sets whether the user can close the modal window at all. Setting to false assumes you don't want to give the user the ability to close the window at all - and that you would do it programmatically. I'd suggest 2 variables one for display and one for user control, did you want to send a PR?

lonagi commented 3 years ago

showClose currently sets whether the user can close the modal window at all. Setting to false assumes you don't want to give the user the ability to close the window at all - and that you would do it programmatically. I'd suggest 2 variables one for display and one for user control, did you want to send a PR?

Yes, your suggestion is ok.