search

Harmonickey / EnHabit

1 stars 0 forks source link

Create Listing When Logged In #14

Closed Harmonickey closed 9 years ago

Harmonickey commented 9 years ago

(BRANCH):hummer/create-listing/14

(DESCRIPTION): The user should be able to create a simple listing of their apartment after logging in.

If so, it needs to be just wide enough for the footer not to word-wrap(the second line all on one line), but not really any more than that.

I like that the sidebar snaps away into a menu bar tho at a certain width.

(COMPLETION REQUIREMENTS): 1. Create new popup modal 2. Remove geocomplete search bar from the sidebar and move to the new popup modal. 3. Add fields to complete for listing entry 4. When user selects an address from the search bar, make the user verify it. 5. Create an ajax request/api endpoint for retrieving info from cookie. 6. When adding to database, the foreign key is the username, so get that from the session information. 7. #21

(PARENT TICKET):none

(DEPENDENT TICKETS):#21, #24, #30

Harmonickey commented 9 years ago

I cannot continue this until the login features from /15 are pushed through to master. There were also a ton of bug fixes that were made along the way in /15.

Saurutobi commented 9 years ago

removed blocked, the dependency is merged to master I've created this branch. just check it out.

Harmonickey commented 9 years ago

thank you. just so everyone is on the same page, I am not implementing the uploading of pictures at the moment. Just basic information so that functionality is there, it will be easy to add in more fields like pictures or other things later.

Harmonickey commented 9 years ago

grabbing in #16 because why not, otherwise, all the other tasks are completed for this ticket. I will do the last part tomorrow

Harmonickey commented 9 years ago

Changed my mind.

ghost commented 9 years ago

Looks good. We'll make a UI ticket later on to add things when we've got a fullyfunctional basic website

Harmonickey commented 9 years ago

deployed to QA successfully

Harmonickey commented 9 years ago

Actually, this may fail QA. I just imagined a case where the user types in an address, clicks on the google autocomplete result, and then deletes characters from the address. The application will have the correct lat and long of the original address but the address will not be correct. This needs to be fixed.

Harmonickey commented 9 years ago

Moved it through again. Just added a couple of lines of validation.

ghost commented 9 years ago

I got the error message. I also think that not every user should be allowed to create listings. It should people who apply as land lords and have been vetted by us to make sure they're not selling somebody else's house or something. But that's a later thing once everything works. For now, this error-ed on Google validation thing./

ghost commented 9 years ago

I'm blocking this until we have a meeting with the other guys. No more work on this until we have a talk about product direction. I have a very clear image in my mind about where we go from here, but I want to make sure the other guys agree.

Harmonickey commented 9 years ago

fixed the bug, but we still need to have the meeting of course

Harmonickey commented 9 years ago

All changes made for #31 and all functionality tested.

Saurutobi commented 9 years ago

I can't view the listing I just made. I made a bogus one and then it wouldn't show me them as a list, and I can't edit it because I can't see it.

Harmonickey commented 9 years ago

I will carry this over into a new branch, I just wanted the api functions. In addition, the list view is #16 , which I did not work on, but did add the button.

Harmonickey commented 9 years ago

I am doing it here too, it will be in release/next, the api works so I will add the UI component as the requirements for the new ticket.

Saurutobi commented 9 years ago

nuked. Remember to delete your local.