search

Harmonickey / Serilog.Sinks.SendGridEmail

Sends the email notification through SendGrid
MIT License
2 stars 3 forks source link

Newtonsoft is not used #1

Closed steveoh closed 3 years ago

steveoh commented 3 years ago

Describe the bug

You include newtonsoft json in the project but it is never used.

Harmonickey commented 3 years ago

True! I have removed it and bumped the version to 2.0.1 should be available sometime today after it's finished uploading to nuget.

steveoh commented 3 years ago

I've vendored this project for now to update other dependencies and adding nullability. I can commit that all back but our formatting is all different and everything is different now.

Harmonickey commented 3 years ago

What formatting? You mean the tab size is different?

Harmonickey commented 3 years ago

Also, if you have changes, feel free to just fork it and/or create a pull request, that way others can benefit from your changes.

steveoh commented 3 years ago

What formatting? You mean the tab size is different?

Well you don't have an editorconfig or omnisharp.json so yeah, tabs converted to spaces, curlies went all over.

Harmonickey commented 3 years ago

Feel free to add one and make a pull request, I don't really mind.