search

Harold-Solbrig / funowl

Pythonic representation of OWL through the OWL functional syntax
Creative Commons Zero v1.0 Universal
50 stars 5 forks source link

remove disallowing rdflib 6.1 #37

Closed cmungall closed 2 years ago

cmungall commented 2 years ago

I have some projects using owlfun that also use rdflib 6.1, I know the prefix ingestion is annoying, but it doesn't cause bugs - can we just make owlfun be less opinionated and let the user decide?

cmungall commented 2 years ago

hmm, no github actions?

hsolbrig commented 2 years ago

I tweaked it so that the actions would work. We still have an issue, however, in that rdflib-shim excludes 6.1, so the rdflib change has no impact -- it is redundant.

It is going to take a bit of work to implement this change, as: 1) we're going to have to come up with a shim equivalent that does what is needed but doesn't exclude 6.1.1 and 2) we're going to have to override or fix several of the unit tests to be more loosey-goosey about the import statements.

The question is how much time we want to spend on this problem. I believe that there is a force function in pipenv -- if someone felt strongly about needing the 6.1.1 changes they could add a line that installs it even if it is disallowed in other modules.

What are the features in 6.1.1 that we aren't getting because of this exclusion?

cmungall commented 2 years ago

Here is the main issue: other libraries sparqlwrapper force you to use 6.1.1 unless you pin to an older version of sparqlwrapper, which itself will have knock-on effects...

https://github.com/RDFLib/sparqlwrapper/blob/master/requirements.txt

On Sat, Apr 9, 2022 at 9:58 AM Harold Solbrig @.***> wrote:

I tweaked it so that the actions would work. We still have an issue, however, in that rdflib-shim excludes 6.1, so the rdflib change has no impact -- it is redundant.

It is going to take a bit of work to implement this change, as:

  1. we're going to have to come up with a shim equivalent that does what is needed but doesn't exclude 6.1.1 and
  2. we're going to have to override or fix several of the unit tests to be more loosey-goosey about the import statements.

The question is how much time we want to spend on this problem. I believe that there is a force function in pipenv -- if someone felt strongly about needing the 6.1.1 changes they could add a line that installs it even if it is disallowed in other modules.

What are the features in 6.1.1 that we aren't getting because of this exclusion?

— Reply to this email directly, view it on GitHub https://github.com/hsolbrig/funowl/pull/37#issuecomment-1094085020, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAMMOM2TEWYXQ4QJIKRGX3VEGZJNANCNFSM5NHURHIA . You are receiving this because you authored the thread.Message ID: @.***>

hsolbrig commented 2 years ago

This was superseded by https://github.com/hsolbrig/funowl/pull/44. I just noticed that rdflib 6.1.0 would still fail the unit tests, but I think we can treat that as a bygone...

This also assumes that the next rdflib release, whatever it may be, will fix this problem.