search

Haroon96 / Warzone-Stats

Discord bot for calculating stats in Call of Duty Warzone
GNU General Public License v3.0
20 stars 10 forks source link

Switch to node-libcurl #81

Closed jhoogstraat closed 2 years ago

jhoogstraat commented 2 years ago

This fixes the cloudflare issues which prevent the bot from accessing the tracker.gg api currently. The system must have curl installed.

jhoogstraat commented 2 years ago

The CA Certificates should normally be provided by the OS. I can just include a copy of Mozilla's CA cert bundle, but thats rather uncommon. Moreover, it creates a new dependency to handle.

What system is the bot running on?

osama-h-rana commented 2 years ago

Hmm, I tested the PR on my own windows machine, but I'm not sure if the same problem would exist on Heroku. @Haroon96 maybe you can check?

jhoogstraat commented 2 years ago

As it turns out, the error is common: https://github.com/JCMais/node-libcurl/blob/develop/COMMON_ISSUES.md I can add the third option.

jhoogstraat commented 2 years ago

Could you try now @osama-h-rana?

osama-h-rana commented 2 years ago

@jhoogstraat working now on windows, sorry it took so long to review. Kinda busy during the week.