Closed dcalvom closed 4 years ago
For some validation libraries in React is mandatory to have a name attribute. It would be nice to be able to add a prop name to the element here: <a rel="noreferrer nofollow" target="_blank" href="https://github.com/HarryChen0506/react-markdown-editor-lite/blob/33dee22156935e1b10dd4c7a8dbddd88fd117957/src/editor/index.jsx#L561">https://github.com/HarryChen0506/react-markdown-editor-lite/blob/33dee22156935e1b10dd4c7a8dbddd88fd117957/src/editor/index.jsx#L561</a></p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/HarryChen0506"><img src="https://avatars.githubusercontent.com/u/21263805?v=4" />HarryChen0506</a> commented <strong> 4 years ago</strong> </div> <div class="markdown-body"> <p>As I understand, you means that <textarea> should be added a prop <code>name</code>.What I want to make sure is that prop <code>name</code> custom (for example, <code>name={this.props.foo}</code>)? or just add a props <code>name='markdown-content'</code> ?</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/HarryChen0506"><img src="https://avatars.githubusercontent.com/u/21263805?v=4" />HarryChen0506</a> commented <strong> 4 years ago</strong> </div> <div class="markdown-body"> <p>OK， I already understand what your mean. Thanks your pull request, and I have merged it.</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/dcalvom"><img src="https://avatars.githubusercontent.com/u/7228045?v=4" />dcalvom</a> commented <strong> 4 years ago</strong> </div> <div class="markdown-body"> <p>Thanks @HarryChen0506! I just add a new pull request. The validation library I use need to access the validity state of the input, therefore is necessary to forward the event into the onEmit method. Thanks again for your help</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/HarryChen0506"><img src="https://avatars.githubusercontent.com/u/21263805?v=4" />HarryChen0506</a> commented <strong> 4 years ago</strong> </div> <div class="markdown-body"> <p>yes, you are right! the best api should contain an event detail, thank you for your contribution！</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/dcalvom"><img src="https://avatars.githubusercontent.com/u/7228045?v=4" />dcalvom</a> commented <strong> 4 years ago</strong> </div> <div class="markdown-body"> <p>Thanks for this great package!</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/dcalvom"><img src="https://avatars.githubusercontent.com/u/7228045?v=4" />dcalvom</a> commented <strong> 4 years ago</strong> </div> <div class="markdown-body"> <p>Would you mind to create a release with this latest change so I can install the package from npm? Sorry to bother.</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/HarryChen0506"><img src="https://avatars.githubusercontent.com/u/21263805?v=4" />HarryChen0506</a> commented <strong> 4 years ago</strong> </div> <div class="markdown-body"> <p>ok, i will public a new release after some hours. </p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/HarryChen0506"><img src="https://avatars.githubusercontent.com/u/21263805?v=4" />HarryChen0506</a> commented <strong> 4 years ago</strong> </div> <div class="markdown-body"> <p>Hello, my friend, I have published a new version(v0.4.4) in NPM. you can use it as follows. :-）</p> <pre><code>handleEditorChange = ({ html, text}, event) => { console.log('handleEditorChange', event) }</code></pre> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/dcalvom"><img src="https://avatars.githubusercontent.com/u/7228045?v=4" />dcalvom</a> commented <strong> 4 years ago</strong> </div> <div class="markdown-body"> <p>Great!!! Thanks man!</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/dcalvom"><img src="https://avatars.githubusercontent.com/u/7228045?v=4" />dcalvom</a> commented <strong> 4 years ago</strong> </div> <div class="markdown-body"> <p>@HarryChen0506 I think is necessary to change the onChage? function in the index.d.ts file to accept the event param as follows:</p> <pre><code> onChange?: (data: { text: string; html: string; }, event: any) => void;</code></pre> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/HarryChen0506"><img src="https://avatars.githubusercontent.com/u/21263805?v=4" />HarryChen0506</a> commented <strong> 4 years ago</strong> </div> <div class="markdown-body"> <p>yes, I forgot it. I will correct it next time. Have a nice experience :-)</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/dcalvom"><img src="https://avatars.githubusercontent.com/u/7228045?v=4" />dcalvom</a> commented <strong> 4 years ago</strong> </div> <div class="markdown-body"> <p>Thaaaanks! Sorry for bother a lot. If you can wrap that in a release, you will make my day. I'm currently patching my local version but this is not sustainable </p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/HarryChen0506"><img src="https://avatars.githubusercontent.com/u/21263805?v=4" />HarryChen0506</a> commented <strong> 4 years ago</strong> </div> <div class="markdown-body"> <p>I am happy to do it, so you don't have to feel sorry. I will fix it after work as soon as possible.</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/dcalvom"><img src="https://avatars.githubusercontent.com/u/7228045?v=4" />dcalvom</a> commented <strong> 4 years ago</strong> </div> <div class="markdown-body"> <p>Awesome! You rock!</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/HarryChen0506"><img src="https://avatars.githubusercontent.com/u/21263805?v=4" />HarryChen0506</a> commented <strong> 4 years ago</strong> </div> <div class="markdown-body"> <p>Hello, the latest version(v0.4.5) has been released. If you have any request, just tell us. :-)</p> </div> </div> <div class="page-bar-simple"> </div> <div class="footer"> <ul class="body"> <li>© <script> document.write(new Date().getFullYear()) </script> Githubissues.</li> <li>Githubissues is a development platform for aggregating issues.</li> </ul> </div> <script src="https://cdn.jsdelivr.net/npm/jquery@3.5.1/dist/jquery.min.js"></script> <script src="/githubissues/assets/js.js"></script> <script src="/githubissues/assets/markdown.js"></script> <script src="https://cdn.jsdelivr.net/gh/highlightjs/cdn-release@11.4.0/build/highlight.min.js"></script> <script src="https://cdn.jsdelivr.net/gh/highlightjs/cdn-release@11.4.0/build/languages/go.min.js"></script> <script> hljs.highlightAll(); </script> </body> </html>
name
For some validation libraries in React is mandatory to have a name attribute. It would be nice to be able to add a prop
nameto the