Add compatibility with CentOS 7

HarryHarcourt / Ansible-RHEL7-CIS-Benchmarks

This repository contains an Ansible Role for RHEL7 / CentOS based on the Center for Internet Security Benchmarks

MIT License

103 stars 73 forks source link

Add compatibility with CentOS 7 #4

Closed martinbaillie closed 6 years ago

martinbaillie commented 6 years ago

I forked this earlier today to make it work on CentOS 7. Would you be interested in merging?

On CentOS 7 latest, variables are like:

ansible_distribution: CentOS
ansible_distribution_version: 7.4.1708

HarryHarcourt commented 6 years ago

Hi Martin I have no concerns with the merge, I also noted some issues around SSH versions, can it wait till next week I am on holiday. Best Ben

HarryHarcourt commented 6 years ago

Hi Martin Looked at the changes, have you tested this against multiple versions of CentOS from a validation perspective? Thus whilst this will enable the validation / changes to the configuration I for CentOS I think it will fail on certain sections of SSH (or actually SSH won't start cleanly after application because a variable applied is not correct). I only tested on CentOS images I could find on Amazon Best Ben

HarryHarcourt commented 6 years ago

Hi Martin Any feedback from my comment? Best Ben

martinbaillie commented 6 years ago

Hi @HarryHarcourt, sorry I missed this first time around. I did not test on multiple versions, just pure upstream latest — CentOS 7.4 (1708) (minimal ISO). Are you seeing issues with other versions of 7.x?

HarryHarcourt commented 6 years ago

Hi Martin Alas yes, I am happy to merge as I like CentOS but need to figure out away of validating that RHEL 7.0 - 7.5 and CentOS 7.4 are supported (and not lower versions). I test RHEL on AWS using the AMI's provided (need to find a faster way using molecule) there are not any clear CentOS AMI's however specific to Version.Release (as CentOS seemed to move to a monthly release bundle). Thoughts are welcome.... Best Ben