HarryR / ethsnarks

A toolkit for viable zk-SNARKS on Ethereum, Web, Mobile and Desktop
GNU Lesser General Public License v3.0
241 stars 57 forks source link

This fixes release / performance builds with OSX Clang #138

Closed HarryR closed 5 years ago

HarryR commented 5 years ago

The main fix is to not use try/except for control flow logic in libfqfft::get_evaluation_domain

This was apparently triggering a compiler bug with OSX's Clang, and was noted by other projects.

This was also causing the 'Cheerp' WASM compiler builds to fail (as compiler doesn't support catching exceptions), and required that the Emscripten builds enable try/catch support.

These modifications: