Closed wanseob closed 4 years ago
This sounds good. Say we call it ethsnarks-python
?
However, I think it would be best if we can switch the ethsnarks
directory in the main (this) repository with a git submodule, or something similar.
Most of the tests don't depend on any of the native code, but there are some which do - I guess those can be excluded from a Python-only repository?
Would this layout work: So you can use the main ethsnarks directory in PYTHONPATH
so it doesn't break compatibility with existing projects?
ethsnarks
ethsnarks
-> ethsnarks-python git submodule (contians python package, __init__.py
etc.)Or would something like this be necessary, to make it compatible with PyPi and installable via pip from a GitHub url etc.
ethsnarks
python
-> ethsnarks-python git submodule
ethsnarks
(contains python package, __init__.py
etc.)The first idea looks good!
ethsnarks
ethsnarks
: https://github.com/harryR/ethsnarks-python git submodule Rather than creating a new separate repository, adding setup.py
like truffle.js
simply solves this issue. Please check my PR #157
This python library is quite useful for zk-SNARKs, so it would be really good if I can use this lib with
If you don't mind can I make it as a PyPI package? My plan is
ethsnarks/ethsnarks