HarryR / ethsnarks

A toolkit for viable zk-SNARKS on Ethereum, Web, Mobile and Desktop
GNU Lesser General Public License v3.0
240 stars 57 forks source link

Python directory ethsnarks/ethsnarks as a PyPI package #155

Closed wanseob closed 4 years ago

wanseob commented 4 years ago

This python library is quite useful for zk-SNARKs, so it would be really good if I can use this lib with

pip install ethsnarks

If you don't mind can I make it as a PyPI package? My plan is

  1. fork this repository
  2. commit the subtree ethsnarks/ethsnarks
  3. Add some setup.py and make it as PyPI package
  4. Transfer ownership back to HarryR
HarryR commented 4 years ago

This sounds good. Say we call it ethsnarks-python ?

However, I think it would be best if we can switch the ethsnarks directory in the main (this) repository with a git submodule, or something similar.

Most of the tests don't depend on any of the native code, but there are some which do - I guess those can be excluded from a Python-only repository?

Would this layout work: So you can use the main ethsnarks directory in PYTHONPATH so it doesn't break compatibility with existing projects?

Or would something like this be necessary, to make it compatible with PyPi and installable via pip from a GitHub url etc.

wanseob commented 4 years ago

The first idea looks good!

wanseob commented 4 years ago

Rather than creating a new separate repository, adding setup.py like truffle.js simply solves this issue. Please check my PR #157