Merkle fixes, Miximus cleanup + security fix

HarryR / ethsnarks

A toolkit for viable zk-SNARKS on Ethereum, Web, Mobile and Desktop

GNU Lesser General Public License v3.0

240 stars 57 forks source link

Merkle fixes, Miximus cleanup + security fix #61

Closed HarryR closed 5 years ago

HarryR commented 5 years ago

This fixes:

Merkle path verification
Improved Merkle path tests
End-to-end JS tests for Miximus
Security bug in Miximus where public inputs were wrong
Upgrade to Solidity 0.4.25
Use built-in pow instead of Python powmod
Alternative inv which uses pow, faster...

HarryR commented 5 years ago

There is an anomalous situation with the OSX build, the pull request succeeded but the build for the push failed in the JS/libmiximus tests with:

libc++abi.dylib: terminating with uncaught exception of type boost::exception_detail::clone_impl<boost::exception_detail::error_info_injector<boost::property_tree::json_parser::json_parser_error> >: <unspecified file>(9): garbage after data
make: *** [truffle-test] Abort trap: 6

garbage after data... so the string isn't being null terminated?