ESPN Api link broken - Failing integration tests

HarryShomer / Hockey-Scraper

Python Package for scraping NHL Play-by-Play and Shift data

http://hockey-data.harryshomer.com

GNU General Public License v3.0

141 stars 47 forks source link

ESPN Api link broken - Failing integration tests #30

Open austinegri opened 1 year ago

austinegri commented 1 year ago

References

Integration tests are failing as the ESPN api link no longer returns game data:

http://www.espn.com/nhl/gamecast/data/masterFeed?lang=en&isAll=true&gameId=400885300
Failing tests
Link usage here

Tested with current 2023 gameId and found link was broken for this as well so ESPN must've changed the url.

Screenshot 2023-04-07 at 13-10-36 ESPN - Serving Sports Fans Anytime Anywhere

Acceptance Criteria

Proper link found and replaced to fetch ESPN game data

austinegri commented 1 year ago

Perhaps ESPN playbyplay tab could be the answer here i.e. https://www.espn.com/nhl/playbyplay/_/gameId/401459832

HarryShomer commented 1 year ago

Hey @austinegri!

Thanks for pointing this out. I actually noted this in one of my last commits (see b59c458e346eae604a8c581269b5ef5df74fb342). I don't think this should be a problem for most recent seasons as I believe the NHL has done a better job of recording the coordinates in the API game feed.

I'm currently very busy with work so I won't have a chance to take a closer look until the summer.

Regards, Harry

austinegri commented 1 year ago

Thanks for the reply @HarryShomer!

My bad I didn't see the recent commit. No worries I understand work is priority, this is a side project and figured it would be good to have a tracking issue.

Do you know around which season would start to have most of the data?

HarryShomer commented 1 year ago

Do you know around which season would start to have most of the data?

Tbh I'm not sure. The NHL has been known to go back and fix old games.

Your best bet is to just try different seasons and see what happens.