Open Harrynoqs opened 1 year ago
Hi @Harrynoqs,
Good job so far! There are some issues that you still need to work on to go to the next project but you are almost there!
According to the project requirements:
At the time of this review, however, these are the pointings:
@Harrynoqs 19 @soulemanou-software 11 @Ellon-M 11.5
As you can see, @Harrynoqs has 8 points more than @soulemanou-software, and 7.5 more than @Ellon-M.
The general rule is that nobody can have more than 5 points than any other team member. That includes the whole team.
Therefore:
That way, we will meet this particular requirement. πͺ
Tip: Just reassign some tasks and/or play with the numbers so the points difference is no more than 5.
Cheers and Happy coding!πππ
Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
Hi @Harrynoqs,
Your project is complete! There is nothing else to say other than... it's time to merge it :shipit: Congratulations! π
Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.
Cheers and Happy coding!πππ
Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
Hi π For this project, we are 3:
@Harrynoqs @Ellon-M @soulemanou-software
Screenshot of the Kanban:
https://github.com/users/Harrynoqs/projects/3/views/1