search

Harrynoqs / Recipe-app

MIT License
1 stars 0 forks source link

RoR group project: set up your Kanban board #14

Open Harrynoqs opened 1 year ago

Harrynoqs commented 1 year ago

Our GitHub project https://github.com/users/Harrynoqs/projects/2/views/1

Our group consists of 2 partners

Mihndim2020 commented 1 year ago

Hi Team,

Good job so far!

To Highlight! :clap: :green_circle:

:heavy_check_mark: Good job with tasks distribution.

There are some issues that you still need to work on to get this project approved, but you are almost there! ALMOST-MINION

Status: Requires Changes ♻️

Check the comments under the review.

Optional suggestions

Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.

N/A

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear or you can get to me on slack using this handle @mihndim. Please, remember to tag me in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

Abenezer-Tilahun commented 1 year ago

Hi @Harrynoqs @degisew

Your project is complete 👍 💯 There is nothing else to say other than... it's time to merge it :shipit: Congratulations! 🎉

Highlights 👏🏻

✔️ Good job for Provide the link to the Kanban board for project ✔️ Good job for provide information about the number of people in your's group. ✔️ Good Job For set up kanban board for RoR group project .

Optional suggestions

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.