RELAY2plate Support and New PWM node

Harsch-Systems / node-red-contrib-pi-plates

Control Pi-Plates from Node-RED

Apache License 2.0

6 stars 7 forks source link

RELAY2plate Support and New PWM node #28

Closed pi-plates closed 2 years ago

pi-plates commented 2 years ago

1) Removed references to MOTORplate in the README file since it is unused for now 2) Added support for the upcoming RELAYplate2 to the RELAY node 3) Created the PWM node which has been tested to work on the DAQC, DAQC2, and TINKERplate.

mharsch commented 2 years ago

These changes look fine; just a couple things:

these changes need to be split across the 2 related repositories (this one and this one)
I think the logic that checks for a valid relay index will crash if you send a '7' to an old relay plate
As a matter of code style consistency, please change any tabs into 4 spaces to match the rest of the code

Let's start with a new pull request to the other repo and then either update or re-do this one.