Open casmpy opened 2 years ago
Okay I will see
@HarshCasper I have to see but you can merge it now
@casmpy That's not how it works — PRs that are reviewed should have those changes that are being requested by the maintainers. Otherwise, it won't make any sense to merge multiple PRs for the same stuff over and over again. If you are not willing to work on the changes, feel free to close the PR.
Okay I will do it
On Fri, Mar 4, 2022 at 10:28 AM Harsh Mishra @.***> wrote:
@casmpy https://github.com/casmpy That's not how it works — PRs that are reviewed should have those changes that are being requested by the maintainers. Otherwise, it won't make any sense to merge multiple PRs for the same stuff over and over again. If you are not willing to work on the changes, feel free to close the PR.
— Reply to this email directly, view it on GitHub https://github.com/HarshCasper/Rotten-Scripts/pull/1307#issuecomment-1058829128, or unsubscribe https://github.com/notifications/unsubscribe-auth/APLCQISCD4I5YDFWVKGJNJTU6GKALANCNFSM5PYFXGFQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you were mentioned.Message ID: @.***>
Fixes #1291
Added this script in BASH file