HarshCasper / Rotten-Scripts

Scripts that will make you go WOW!

MIT License

1.48k stars 489 forks source link

(feature): Converting Twitter_Unfollowers script to Npm Package #1336

Open Jagrutiti opened 2 years ago

Jagrutiti commented 2 years ago

Description

Please include a summary of the change and which issue is fixed. List any dependencies that are required for this change.

Fixes #1327

Type of change

Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update
[ ] Documentation Update

Checklist:

[x] My code follows the style guidelines(Clean Code) of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have created a helpful and easy to understand README.md
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests/screenshots(if any) that prove my fix is effective or that my feature works

ghost commented 2 years ago

CodeSee Review Map:

Review in an interactive map

View more CodeSee Maps

Legend

CodeSee Map Legend

Jagrutiti commented 2 years ago

Hi @HarshCasper the package is published here.

Changes I would like to propose:

Not sure how the bearer-key should be added. Maybe prompt users as we prompt them to enter their username. Any suggestions would be helpful here.
Add new keywords in package.json. For now, I have added only twitter.

When we import the package after installing, it asks for dependency to be met:

prompt-sync
needle

I will add them in package.json.

Will release a minor version once all the changes are finalized.

HarshCasper commented 2 years ago

Hi @Jagrutiti

We can prompt them in the same way when we ask them to enter their username. We can also ask them to export the API keys as TWITTER_BEARER_KEY before using the package. Let me know if that sounds helpful!

You can add keywords like unfollower, twitter-api, twitter-utility as well.

Jagrutiti commented 2 years ago

Hi @HarshCasper. Published 1.0.1 version of the package.