HarshKapadia2 / git_basics

A PWA and TWA for Git and GitHub concepts and commands.
https://harshkapadia2.github.io/git_basics
Creative Commons Attribution Share Alike 4.0 International
105 stars 20 forks source link

Fix link description (#23) #46

Closed Rodrigue819 closed 4 years ago

HarshKapadia2 commented 4 years ago

Thank you for the PR, @Rodrigue819!

Changes:

HarshKapadia2 commented 4 years ago

Hey @Rodrigue819 I was going through the files and found one link in git_merge.adoc that you missed. Could you please correct that, generate a new index.html and make a commit?

A picture for your ref (the 2nd line has the link that you missed):

image

HarshKapadia2 commented 4 years ago

Also, you have not covered the second part of the issue:

Remove hyperlinks on pictures.

Just remove the link attribute in the pictures (if present), generate index.html and make a commit.

The files git_add.adoc, git_pull.adoc, git_merge.adoc and git_push.adoc have pictures with the link attribute. (Just check other files as well, to be sure. I couldn't find any more.)

Rodrigue819 commented 4 years ago

@HarshKapadia2 I've made the change for the missed link. I did another PR with the link in the picture. I originally missed that one and did not want to mess with the PR that you already had revised. Look at PR #48

HarshKapadia2 commented 4 years ago

In the future, please remember to make a new branch for every PR. It is not a good practice to make PRs from the master branch. If you don't know how to do that, you can learn to make a PR. 😃

HarshKapadia2 commented 4 years ago

I did another PR with the link in the picture. I originally missed that one and did not want to mess with the PR that you already had revised. Look at PR #48

Oh my bad. I'll have a look.

HarshKapadia2 commented 4 years ago

The PRs for issue #23 are #46 and #49.