Closed Rodrigue819 closed 4 years ago
Hey @Rodrigue819 I was going through the files and found one link in git_merge.adoc
that you missed. Could you please correct that, generate a new index.html
and make a commit?
A picture for your ref (the 2nd line has the link that you missed):
Also, you have not covered the second part of the issue:
Remove hyperlinks on pictures.
Just remove the link
attribute in the pictures (if present), generate index.html
and make a commit.
The files git_add.adoc
, git_pull.adoc
, git_merge.adoc
and git_push.adoc
have pictures with the link
attribute. (Just check other files as well, to be sure. I couldn't find any more.)
@HarshKapadia2 I've made the change for the missed link. I did another PR with the link in the picture. I originally missed that one and did not want to mess with the PR that you already had revised. Look at PR #48
In the future, please remember to make a new branch for every PR. It is not a good practice to make PRs from the master branch. If you don't know how to do that, you can learn to make a PR. 😃
I did another PR with the link in the picture. I originally missed that one and did not want to mess with the PR that you already had revised. Look at PR #48
Oh my bad. I'll have a look.
The PRs for issue #23 are #46 and #49.
Thank you for the PR, @Rodrigue819!
Changes:
what_is_github.adoc
file. There is an extra[
. Please make another commit to remove it.CONTRIBUTING.md
file to generate anindex.html
file. Please make another commit to include the file after the first point is covered.