search

HarshKapadia2 / git_basics

A PWA and TWA for Git and GitHub concepts and commands.
https://harshkapadia2.github.io/git_basics
Creative Commons Attribution Share Alike 4.0 International
105 stars 20 forks source link

External link in new tab (#28) #48

Closed Rodrigue819 closed 4 years ago

Rodrigue819 commented 4 years ago

Must merge the 2 PR on task #23 before this one. Sorry about posting them in the wrong order.

HarshKapadia2 commented 4 years ago

Must merge the 2 PR on task #23 before this one. Sorry about posting them in the wrong order.

No problem, it happens. Thank you for the PRs!

HarshKapadia2 commented 4 years ago

Could you keep the original text for this link in git_bash.adoc? (Add [role=external,window=_blank] to it though.) image

HarshKapadia2 commented 4 years ago

Also, I just realised that you have not made the changes mentioned in issues #23 and #28 for index.adoc. Please make a separate commit for this (with the commit message referencing both issues) in this PR after you finish with the git_bash.adoc commit as mentioned in the above comment. Remember to generate the index.html file again.

HarshKapadia2 commented 4 years ago

Why did you close the PR, @Rodrigue819!? You just have a few more changes to make!

Rodrigue819 commented 4 years ago

It's just the time I do the ajustments. Don't worry I'll reopen it shortly.

From: Harsh Kapadia notifications@github.com Sent: Saturday, October 10, 2020 3:31:33 AM To: HarshKapadia2/git_basics git_basics@noreply.github.com Cc: Rodrigue819 stephane_poirier@hotmail.com; Mention mention@noreply.github.com Subject: Re: [HarshKapadia2/git_basics] External link in new tab (#28) (#48)

Why did you close the PR, @Rodrigue819https://github.com/Rodrigue819!? You just have a few more changes to make!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/HarshKapadia2/git_basics/pull/48#issuecomment-706504431, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AGKTEKMN5EOSZGOOFT4JR6TSKAEVLANCNFSM4SKNRHFQ.

HarshKapadia2 commented 4 years ago

You should keep a PR open while you work on it. Closing a PR implies that you aren't going to be working on it anymore. Do remember that in the future!

Rodrigue819 commented 4 years ago

I'm done with the index. There's only that "these" i'm not sure if I should fix. image I don't really know how I could change the phrase to remove "these" if I need to. I thought about simply removing these and put the link on "Git terms" but i'm not sure how it sounds.

HarshKapadia2 commented 4 years ago

'One might want to familiarize themselves with some [Git terms] before starting...' Does that work?

HarshKapadia2 commented 4 years ago

Just reminding you that the following change in this PR is pending as well: https://github.com/HarshKapadia2/git_basics/pull/48#issuecomment-706381662

Rodrigue819 commented 4 years ago

Did the change in index.adoc. The change in #48 was done in commit a2bb662. Hope everything is ok now!

HarshKapadia2 commented 4 years ago

My bad! I didn't see that! Things seem fine.

Thank you for all the PRs, @Rodrigue819!

By the way, I am conducting a session on Hacktoberfest and Open Source tomorrow (Oct 11) at 3PM IST. You can register and view the details at https://bit.ly/otcHacktoberfest1 if you're interested.

KartikSoneji commented 4 years ago

@Rodrigue819 GitHub has an excellent feature of being able to mark a PR as draft. Marking a PR as draft is a good way to signify that it is not ready yet, but you are working on it.

Docs about draft Pull Requests

Rodrigue819 commented 4 years ago

Thanks for that cue. Will use it!!

Get Outlook for Androidhttps://aka.ms/ghei36

From: Kartik Soneji notifications@github.com Sent: Saturday, October 10, 2020 2:53:42 PM To: HarshKapadia2/git_basics git_basics@noreply.github.com Cc: Rodrigue819 stephane_poirier@hotmail.com; Mention mention@noreply.github.com Subject: Re: [HarshKapadia2/git_basics] External link in new tab (#28) (#48)

@Rodrigue819https://github.com/Rodrigue819 GitHub has an excellent feature of being able to mark a PR as draft. Marking a PR as draft is a good way to signify that it is not ready yet, but you are working on it.

Docs about draft Pull Requestshttps://docs.github.com/en/free-pro-team@latest/github/collaborating-with-issues-and-pull-requests/about-pull-requests#draft-pull-requests

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/HarshKapadia2/git_basics/pull/48#issuecomment-706595345, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AGKTEKIN47OXOZDP4HEXKP3SKCUTNANCNFSM4SKNRHFQ.