Add notice regarding main and master (#47)

HarshKapadia2 / git_basics

A PWA and TWA for Git and GitHub concepts and commands.

https://harshkapadia2.github.io/git_basics

Creative Commons Attribution Share Alike 4.0 International

104 stars 20 forks source link

Add notice regarding main and master (#47) #51

Closed tusharnankani closed 4 years ago

tusharnankani commented 4 years ago

Fixes #47
Added the Admonition - NOTE regarding main and master.
- Let me know if something is to be changed.
Fixed minor typo (requirememnts -> requirements) and README errors.

HarshKapadia2 commented 4 years ago

Thank you for the PR!

Fixed minor typo (requirememnts -> requirements) and README errors.

Thank you for these extra changes, but in the future please open a new PR for such changes.

Coming to the NOTE:

I think the note should be placed just below the last note (on 'Git terms') in the 'Prefece' section.

The language of the note is not the same as the entire web site.
- Pronouns are either not included at all or third person pronouns like 'they' and 'one' are used.
Please generate an index.html file using Asciidoctor as instructed in the CONTRIBUTING.md file.

tusharnankani commented 4 years ago

Thank you for these extra changes, but in the future please open a new PR for such changes.

My bad! Fixed the commits, created a different PR (#54) 👍🏻

The language of the note is not the same as the entire web site.

Pronouns are either not included at all or third-person pronouns like 'they' and 'one' are used.

Please generate an index.html file using Asciidoctor as instructed in the CONTRIBUTING.md file.

Done 👍🏻

tusharnankani commented 4 years ago

I think the note should be placed just below the last note (on 'Git terms') in the 'Preface' section.

Fixed 👍🏻

HarshKapadia2 commented 4 years ago

Thank you for these extra changes, but in the future please open a new PR for such changes.

The changes were supposed to be made in future PRs, not in this PR.

Now to keep the commit history of the repo clean and straightforward, please open a new PR for issue #47. Please add a reference to this PR in the new PR's comments.

Also, do view the CONTRIBUTING.md file again, as it has been modified.

Sorry for the inconvenience caused.

tusharnankani commented 4 years ago

Now to keep the commit history of the repo clean and straightforward, please open a new PR for issue #47. Please add a reference to this PR in the new PR's comments.

Done via #57