Add --allow-empty flag - Githubissues

HarshKapadia2 / git_basics

A PWA and TWA for Git and GitHub concepts and commands.

https://harshkapadia2.github.io/git_basics

Creative Commons Attribution Share Alike 4.0 International

104 stars 20 forks source link

Add --allow-empty flag #90

Closed MahmoudDawood closed 2 years ago

MahmoudDawood commented 2 years ago

[x] Add 'Push Empty Git Commits'

HarshKapadia2 commented 2 years ago

Thank you for the PR @MahmoudDawood!

Some changes that I would request you to make

Shift this option below the -a or --all option.
Add a point that talks about what the --allow-empty option does and make that the first point.
- Please keep the language requirements in mind.
The point on building a project without changes should be the 2nd point and can be framed as 'One usecase can be to trigger a CI/CD workflow without making changes to the project.'.
The git alias point is not required.

MahmoudDawood commented 2 years ago

Thank you for the feedback @HarshKapadia2!

Was it done right this time?

HarshKapadia2 commented 2 years ago

Two more things to be done, @MahmoudDawood

Change the example to git commit --allow-empty -m "<commit_message>"
Use interactive rebasing to squash all your commits into one commit with the commit message ':truck: update: Add `--allow-empty` option (#85)' and force push to your branch. LMK if you don't understand that.

HarshKapadia2 commented 2 years ago

Any updates, @MahmoudDawood? Please LMK if you're having any issues.

MahmoudDawood commented 2 years ago

Sorry for the late reply, today was my free day xD I'll be back tomorrow on it if it's ok with you. Thanks for your reminder Harsh!

On Mon, Jan 10, 2022, 01:57 Harsh Kapadia @.***> wrote:

Any updates, @MahmoudDawood https://github.com/MahmoudDawood? Please LMK if you're having any issues.

— Reply to this email directly, view it on GitHub https://github.com/HarshKapadia2/git_basics/pull/90#issuecomment-1008450007, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHK7PHIMRKMIM73JVQS7OVDUVIOGXANCNFSM5LPKA3LA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you were mentioned.Message ID: @.***>

HarshKapadia2 commented 2 years ago

Sure, no issues.

MahmoudDawood commented 2 years ago

@HarshKapadia2 I had issues with git couldn't squash past commits so I've made a new clean pull request to be merged with all changes added. Sorry for the mess, it's my first issue.

MahmoudDawood commented 2 years ago

@HarshKapadia2 Could you have a look at it?

HarshKapadia2 commented 2 years ago

LGTM. I rebased the commits.

Thank you for the contribution, @MahmoudDawood!

MahmoudDawood commented 2 years ago

@HarshKapadia2 Woow! Thanks for your support bro <3