search

HarshKapadia2 / one-or-two

A hand gesture model web app to detect 1 and 2 in a picture.
https://one-or-two.herokuapp.com/
MIT License
5 stars 4 forks source link

Add disabled button function #17

Closed Haroonchik closed 4 years ago

Haroonchik commented 4 years ago

Added the function to disable the button and added the disabled property to the home-page.css file

HarshKapadia2 commented 4 years ago

Thank you for the PR! You've handled the issue well 👍

Just one change. In ./templates/home-page.html, could you please include the script in the head block with a defer attribute? Example:

{% block head %}
    <script defer src="{{ url_for('static', filename='js/home-page.js') }}"></script>
{% endblock %}
Haroonchik commented 4 years ago

@HarshKapadia2 Ready. You can please add to the PR that you have approved add label: hacktoberfest-accepted. You can see how to do this here: https://hacktoberfest.digitalocean.com/hacktoberfest-update

HarshKapadia2 commented 4 years ago

You can please add to the PR that you have approved add label: hacktoberfest-accepted. You can see how to do this here: hacktoberfest.digitalocean.com/hacktoberfest-update

I have already met this criteria. The repo has a hacktoberfest topic and once I merge your PR, it will be valid for Hacktoberfest 2020. Don't worry.

Haroonchik commented 4 years ago

@HarshKapadia2 Ok😁

Haroonchik commented 4 years ago

@HarshKapadia2 Hastened in that commit and was wrong. Now everything is all right.

Haroonchik commented 4 years ago

@HarshKapadia2 I did it )