Add 404 page html - Githubissues

HarshKapadia2 / one-or-two

A hand gesture model web app to detect 1 and 2 in a picture.

https://one-or-two.herokuapp.com/

MIT License

5 stars 4 forks source link

Add 404 page html #19

Closed Haroonchik closed 1 year ago

HarshKapadia2 commented 4 years ago

The error text is quite unreadable. I would prefer the same font as the entire site with a picture (if you feel like it).
Nice thinking of adding a button, but please let the text be 'Home' instead of 'Main'.

I just realised that it would be better if there was one common template for all errors where the error code (Eg: 404, 500) and error message (Eg: NOT FOUND, INTERNAL SERVER ERROR) were just passed in as and when the error occurred.

Example: A Node.js project Food Oye that I had done. (Live web app)

The status, status_descp and err_trace in the 1st pic get populated in the final output (2nd pic)

A similar thing has to be done in Flask.

Do you think you can do this? Sorry for changing the original issue. If you can't take it up, it's completely okay, but just let me know.

HarshKapadia2 commented 4 years ago

Let me know if you can make the new changes that I suggested. If not, I'll accept this PR and then make another issue for that. If you take up the new issue, I'll close this PR and issues #6 and #7 and create a new issue that you can take up. A lot of the code from this PR will be the same for the new issue, so you will just have to make some additions. Let me know your decision.

Haroonchik commented 4 years ago

@HarshKapadia2 Let's then accepted this PR and in the new one I will try to do the task that you described above.

HarshKapadia2 commented 4 years ago

Wouldn't it be better to directly go to a new PR?

If you're not able to do the new PR, I'll merge this one. I'll not close this PR until that new PR is merged. So finish the tasks for this PR and then use the same code for the new PR, just adding in the dynamic stuff. Tasks for this PR (as mentioned above):

The error text is quite unreadable. I would prefer the same font as the entire site with a picture (if you feel like it). Nice thinking of adding a button, but please let the text be 'Home' instead of 'Main'.

Let me know what you think.

Haroonchik commented 4 years ago

@HarshKapadia2 Ok, I got it, I close the tasks for this PR and then open a new one to add a dynamic display of the error code.

HarshKapadia2 commented 4 years ago

Finish this PR's tasks and then leave it alone. I will make a new issue for the new PR. Open a PR once I make that new issue.

Haroonchik commented 4 years ago

@HarshKapadia2 Use a picture that is in the title?

HarshKapadia2 commented 4 years ago

Yeah that will work. It is a .ico file though. Don't use that. Use the SVG version.

Haroonchik commented 4 years ago

@HarshKapadia2 Check.

HarshKapadia2 commented 4 years ago

Nice thinking of adding a button, but please let the text be 'Home' instead of 'Main'.

Just make this change. Everything else is fine!

Haroonchik commented 4 years ago

@HarshKapadia2 done

HarshKapadia2 commented 4 years ago

Awesome! You can now start working on issue #20.

Haroonchik commented 4 years ago

@HarshKapadia2 Can you merge this PR ? I want to get data to master

HarshKapadia2 commented 4 years ago

But the point was to use this new code to make a new PR altogether and merge this PR only if you aren't able to complete the new PR.

Haroonchik commented 4 years ago

@HarshKapadia2 Hello, check this PR pleace