Improve UI. - Githubissues

HarshKapadia2 / one-or-two

A hand gesture model web app to detect 1 and 2 in a picture.

https://one-or-two.herokuapp.com/

MIT License

5 stars 4 forks source link

Closed KartikSoneji closed 4 years ago

KartikSoneji commented 4 years ago

Change "1" and "2" to emojis.
Updated output screen.
Add accept=".png,.jpg,.jpeg" to file input to filter files shown in file chooser.
Add required attribute to file input to prevent submission of empty form.

tusharnankani commented 4 years ago

@KartikSoneji I was about to make improvements in the User Interface, but no one could have done it better, loved the changes ^_^

HarshKapadia2 commented 4 years ago

Thank you, @tusharnankani for considering making improvements! 💛 I agree with you! @KartikSoneji is awesome and I love the changes as well! 🔥

HarshKapadia2 commented 4 years ago

I would've liked more atomic commits @KartikSoneji.

tusharnankani commented 4 years ago

@HarshKapadia2

I would've liked more atomic commits @KartikSoneji.

What do you mean by atomic commits? Does it mean a different PR for every different file commit?

HarshKapadia2 commented 4 years ago

More commits in the same PR. More commits with each change being one commit (atomic commits) and in the same PR because all the changes are related.