Move internal CSS to an external file.

HarshKapadia2 / one-or-two

A hand gesture model web app to detect 1 and 2 in a picture.

https://one-or-two.herokuapp.com/

MIT License

5 stars 4 forks source link

Closed HarshKapadia2 closed 3 years ago

HarshKapadia2 commented 4 years ago

./templates/github-corner.html has CSS in <style></style> tags.
Remove the <style> tag and add the CSS code within it to a new file ./static/css/github-corner.css.
Add a link to the github-corner.css file in ./templates/base.html.

clairecharles commented 3 years ago

Hey @HarshKapadia2 would love to take this on

HarshKapadia2 commented 3 years ago

Go ahead, @claire-me!

clairecharles commented 3 years ago

Hey, @HarshKapadia2 should I add the link of the external CSS ./static/css/github-corner.css to the ./templates/css/github-corner.html

HarshKapadia2 commented 3 years ago

No, please add it only to ./templates/base.html as mentioned in the 3rd point of the original comment.

clairecharles commented 3 years ago

Hey, @HarshKapadia2 just made the pull request please check it out