Closed TerroR75 closed 1 year ago
vercel[bot]
commented
1 year ago The latest updates on your projects. Learn more about Vercel for Git ↗︎
| Name | Status | Preview | Comments | Updated (UTC) |
|---|---|---|---|---|
| periodically-webapp | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Aug 1, 2023 5:09pm |
netlify[bot]
commented
1 year ago | Name | Link |
|---|---|
| Latest commit | a03e57c949bb3d8df3e0d3852a7ced76bc2730d8 |
| Latest deploy log | https://app.netlify.com/sites/stellular-kleicha-524289/deploys/64c93b9e4a89cf00088e451e |
| Deploy Preview | https://deploy-preview-49--stellular-kleicha-524289.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
TerroR75
commented
1 year ago @HarshKumarraghav Hey! Just wanted to ask, is there anything wrong with my solution? I would love to get a feedback and review from you :) I'm open minded and if there is anything that should be corrected, or maybe quality of this code is not satisfactory, please let me know!
HarshKumarraghav
commented
1 year ago @HarshKumarraghav Hey! Just wanted to ask, is there anything wrong with my solution? I would love to get a feedback and review from you :) I'm open minded and if there is anything that should be corrected, or maybe quality of this code is not satisfactory, please let me know!
hello @TerroR75 sorry for not replying currently I'm busy with some personal stuff..... and about the commit the build does not have a loading state we cant understand if is it even working or not you can see your code deployment here. https://deploy-preview-49--stellular-kleicha-524289.netlify.app/
TerroR75
commented
1 year ago hello @TerroR75 sorry for not replying currently I'm busy with some personal stuff..... and about the commit the build does not have a loading state we cant understand if is it even working or not you can see your code deployment here. https://deploy-preview-49--stellular-kleicha-524289.netlify.app/
All good :) Thank you for reply, fixed some issues with updated code, now its loading properly and filtering works as expected, check these changes whenever you can! Best regards, Kamil
Functionality is the same, especially checked util function Debounce if it still works as intended, and it seems like it does. Because of different wrapping settings with Prettier it may seem like there were many more changes, but some files needed just an interface types defined.
Removed custom attribute "Discovered" from 1 line in 3 different files (PeriodicTable.tsx - line 194, ExploreData.tsx - line 155, Header.tsx - line 200) because TypeScript threw an error.
Tried to avoid type "any" as much as possible, except for _app.tsx, because here I didn't really know which type would fit best in the interface.
I'm testing everything on my local machine using dev server, and everything looks like it's working fine, no errors in the console and in IDE.
Type safety is improved, here is an example:
When using npm run build however, I'm getting this error:
It's probably not because of my changes, because I cloned the original repository and the error is exactly the same, so it may be something on my side.