Harshal0902 / Hacktoberfest

Project ideas for Hacktoberfest 2021
5 stars 11 forks source link

add NodeJS email-sender #31

Closed ahmadfaizan965 closed 2 years ago

ahmadfaizan965 commented 2 years ago

Proposed changes

Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.

Types of changes

What types of changes does your code introduce? Put an x in the boxes that apply

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

ahmadfaizan965 commented 2 years ago

pretty terrible README documentation 😂, need to update it later.

Harshal0902 commented 2 years ago

@ahmadfaizan965 remove the node_modules folder, we don't need that

ahmadfaizan965 commented 2 years ago

@ahmadfaizan965 remove the node_modules folder, we don't need that

should we add the command to install the dependencies in README ?

Harshal0902 commented 2 years ago

If you could add, that would be great

ahmadfaizan965 commented 2 years ago

changes made.