search

HarshilShah / DeckTransition

A library to recreate the iOS Apple Music now playing transition
MIT License
2.19k stars 168 forks source link

Update README.md #70

Closed TheAbstractDev closed 6 years ago

HarshilShah commented 6 years ago

Closing this because the existing documentation is correct and works as expected.

If you have a problem with a particular bit of code in the library, please open an issue or PR about it; working around a problem you haven't even described by just modifying the ReadMe is poor form.

TheAbstractDev commented 6 years ago

Create a new empty project and create a segue with the DeckSegue class.

Tell me if it's working !

HarshilShah commented 6 years ago

I'm not sure where you're going wrong. I just started a blank new project, added just the DeckTransition pod, and it's working fine here. You can see for yourself here: DeckTest.zip

Here are the segue's properties:

screen shot 2018-04-05 at 3 21 52 pm

You don't even need to set those manually; Xcode shows you a menu when you create a Segue, and you can just select custom and then deck from there:

screen shot 2018-04-05 at 3 22 29 pm screen shot 2018-04-05 at 3 22 34 pm

Again, if you have a problem, it's probably best to at least try to explain it or upload a reproducing project yourself. A PR with a hack and asking the developer to reproduce your problem — again, with 0 explanation as to what your problem even is — is not how this works.

TheAbstractDev commented 6 years ago

I see that it's working for you. I use it with Carthage and it's not working, I had to create a custom UIStoryboardSegue to get it working.

HarshilShah commented 6 years ago

It's working with Carthage as well. Feel free to file a separate issue or PR once you figure out what your problem is.