Modifiable dismissThreshold

HarshilShah / DeckTransition

A library to recreate the iOS Apple Music now playing transition

MIT License

2.19k stars 168 forks source link

Modifiable dismissThreshold #76

Closed paulofierro closed 6 years ago

paulofierro commented 6 years ago

For #75.

In my app some testers were finding the swipe to dismiss to be too difficult to complete. I tweaked the dismissThreshold to 120 and found that this made it much easier for them.

With these changes you can now pass in an optional threshold, e.g.

let transitionDelegate = DeckTransitioningDelegate(dismissThreshold: 120)

HarshilShah commented 6 years ago

Hi there,

The project as it is will soon have a massive architectural change that will change how the dismiss gesture works (it will be an interactive transition).

An RFC for that will be up soon. I’m closing this issue for now since the design I’ll be proposing handles this entirely differently, and I’ll post a link to that RFC here when it’s up.

_{Sent with GitHawk}