search

HarshilShah / DeckTransition

A library to recreate the iOS Apple Music now playing transition
MIT License
2.19k stars 168 forks source link

Calculating content's height according to it's internal constraints #83

Closed rkreutz-teamwork closed 6 years ago

rkreutz-teamwork commented 6 years ago

Calculating content's height according to it's internal constraints and using that as the modal's height. If the constraints are not properly set, i.e. when systemLayoutSizeFitting returns a height of 0 we use the default height.

HarshilShah commented 6 years ago

Hi there, and thank you for the pull request.

One issue with self-sizing view controllers is that they conflict with presenting multiple Deck modals on top of each other (#41, #43). Since the design has the presenting view “shrink” as the modal slides up, this design breaks as both the presenting and modals can be self-sizing Deck views.

It’s gonna have to be a choice between self-sizing and recursive modals, and I feel like I can’t make that decision unilaterally.

I’m closing this PR for now, and will bring up this topic in an upcoming RFC that changes significant things about the project.