Hartie95 / PokemonCheatPlugin

55 stars 18 forks source link

Exp cheat and opponent 1 HP #3

Closed MrNbaYoh closed 8 years ago

MrNbaYoh commented 8 years ago

I just added the 1 000 000 EXP cheat and another which set the opponent's HP to 1.

Hartie95 commented 8 years ago

I will check it out later today, but from what I have read it seems good.

Hartie95 commented 8 years ago

There seems to be a bug with the 1HP cheat, if you enable it, and battle against a Pokemon, you will fade out after you attacked sucessfully and gained the xp, maybe you could fix it with an check if the value is higher than the target or a button combination. There seems also be a problem with the new timing and the wild encounter modifier and update dexnav cheat, if you change the route(only if it needs to load it, like through doors or flying, tested with route 103), maybe this is fixable if you add something like speed levels for cheats. (Only checked it in ORAS)

MrNbaYoh commented 8 years ago

I fixed the bug with the 1HP cheat, now it replaces only if the data is greater than 1. But what is the problem with the dexnav, everything seems to work.

Hartie95 commented 8 years ago

I used the random encounter cheat together with the update dexnav cheat, but everytime I used Latios to fly to a route, it crashed. Without the dexnav cheat enabled it worked. This also appeared while changing the route in a way, were it reloads everything(like from route 110 to 103 in oras)

MrNbaYoh commented 8 years ago

Well, I made some tests and it is definitively not related with the refresh rate. It crashes with random encounter only , I don't know yet why.

Hartie95 commented 8 years ago

Then I will do some testing later today or tomorow, and merge your pr now. After the problem is found and fixed I will release the next version.

Hartie95 commented 8 years ago

was the hp fix already pushed to your fork or will it need a new pr(since I merged it without asking this before)?

MrNbaYoh commented 8 years ago

It was not yet pushed to my fork, I will do it later.