Hartie95 / PokemonCheatPlugin

55 stars 18 forks source link

New shiny cheat #6

Closed MrNbaYoh closed 8 years ago

MrNbaYoh commented 8 years ago

This adds my new shiny cheat based on RNG PID generation. It allows us to make every pokemon generated shiny (except shiny locked ones I suppose). If you want some details about how it works, ask me.

Hartie95 commented 8 years ago

Thanks for your work, it seems to work perfectly, but what are the exact differences between both shiny cheats, maybe it would be better to remove the old one, or make them or entrys.

MrNbaYoh commented 8 years ago

The main difference is that this one is working in any case because the PID generation is affected. The other one is just replacing the PID of the monster after it was set, and only works during battles. Well, maybe it would be better to make them "or entries".

Hartie95 commented 8 years ago

Thanks I will merge it and update the readme later today or tomorrow. If you want, I will make it an or entry(because of the different categorys it will be only on the program side, not the visual, but I think thats why you said "or entry") while making the release ready.

MrNbaYoh commented 8 years ago

Ok thanks. I will write up something on that because it really needs to be explained I think. It would be an occasion to explain the PID generation routine.

Hartie95 commented 8 years ago

Now you should be able to edit the wiki(and push to this repo, but please don't push to it directly) I will create a page for the shiny cheats, where I will paste the text you sended me a time ago about the first shiny cheat.

MrNbaYoh commented 8 years ago

Oh, that's cool. I will, of course, not push directly there. I like the pull requests :) Anyway, thanks.