search

Harudas / Asp_Net_MVC_Workshop1

0 stars 0 forks source link

[CodeReview]-Coding Style & Coding Quality #4

Open GSSBilly opened 5 years ago

GSSBilly commented 5 years ago

命名原則

[使用有意義、符合語意命名]

https://github.com/Harudas/Asp_Net_MVC_Workshop1/blob/2fa055ab0fc7a48fa04f438d02805496fb18df4a/Book_final/Controllers/HomeController.cs#L10

https://github.com/Harudas/Asp_Net_MVC_Workshop1/blob/2fa055ab0fc7a48fa04f438d02805496fb18df4a/Book_final/Controllers/HomeController.cs#L58

GSSBilly commented 5 years ago

DRY 原則(Do not repeat yourself)

[重複的 Script 設定， 請善用 Layout]

https://github.com/Harudas/Asp_Net_MVC_Workshop1/blob/2fa055ab0fc7a48fa04f438d02805496fb18df4a/Book_final/Views/Home/Create.cshtml#L85-L87

https://github.com/Harudas/Asp_Net_MVC_Workshop1/blob/2fa055ab0fc7a48fa04f438d02805496fb18df4a/Book_final/Views/Home/Edit.cshtml#L116-L118

GSSBilly commented 5 years ago

一致性

[htmlAttributes，具名參數使用與否請維持一致性]

https://github.com/Harudas/Asp_Net_MVC_Workshop1/blob/2fa055ab0fc7a48fa04f438d02805496fb18df4a/Book_final/Views/Home/Create.cshtml#L17

https://github.com/Harudas/Asp_Net_MVC_Workshop1/blob/2fa055ab0fc7a48fa04f438d02805496fb18df4a/Book_final/Views/Home/Create.cshtml#L19

[私有變數小寫]

https://github.com/Harudas/Asp_Net_MVC_Workshop1/blob/2fa055ab0fc7a48fa04f438d02805496fb18df4a/Book_final/Controllers/HomeController.cs#L56

https://github.com/Harudas/Asp_Net_MVC_Workshop1/blob/2fa055ab0fc7a48fa04f438d02805496fb18df4a/Book_final/Controllers/HomeController.cs#L38

[公有 Fuction 大寫]

https://github.com/Harudas/Asp_Net_MVC_Workshop1/blob/2fa055ab0fc7a48fa04f438d02805496fb18df4a/Book_final/Controllers/HomeController.cs#L78

GSSBilly commented 5 years ago

冗餘檔案

[未使用的 View]

Views/Home/About Views/Home/Contact

GSSBilly commented 5 years ago

良好 & 有意義 & 格式正確註解

https://github.com/Harudas/Asp_Net_MVC_Workshop1/blob/2fa055ab0fc7a48fa04f438d02805496fb18df4a/Book_final/Controllers/HomeController.cs#L10