Harvard-ATG / hxat

Contains the currently-in-development project by HarvardX to bring the annotation tool currently living in the edX platform to a more accessible LTI implementation.
5 stars 1 forks source link

unable to create new assignment in dev (to test new Admin UI functionality) #68

Closed ShannonRice closed 8 years ago

ShannonRice commented 8 years ago

[ANNO-127 in Jira]

I am unable to create a new assignment in Dev. (to test out the new Admin UI) Steps to recreate: 1) Go to dialog box to create a new assignment. 2) Select "create a new source" 3) Fill out fields of dialogue box that comes up. At this point, a white box appears, when it is closed, the following Errors appear (See attachment) Attachments

Screen Shot 2016-07-13 at 3.50.45 PM.png 339 kB5 minutes ago screen shot 2016-07-13 at 3 50 45 pm

arthurian commented 8 years ago

@ShannonRice I'm having trouble duplicating this error exactly as shown in your screenshot. When I submit the form to create a new source, it appears to submit OK, although the dialog window just goes blank and never closes. Looking in the developer console, I see a Javascript-related error:

_/static/vendors/development/ExpandedRelatedObjectLookups.js:93 Uncaught TypeError: window.add_sourcerow is not a function

screen shot 2016-07-26 at 5 40 52 pm

I'll do some more investigating...

arthurian commented 8 years ago

@ShannonRice ... so after more investigating, I was able to duplicate the error: it occurs if you try to save an assignment without any sources, whether that's a source you've just created, or a source you've selected from the existing repository. So I see two things that need to be fixed here:

  1. We need to fix the popup dialog so that when you click "save" on the new source, it properly adds the new source to the assignment in the main browser window (this is not happening because of the error I posted in my previous comment).
  2. We need to fix the assignment submission handler so that it's possible to either (a) create an assignment without any sources attached or (b) displays a friendly warning message to the user that they are required to attach at least one source in order to create an assignment. What was the previous/existing behavior on production?

@lduarte1991 Are you aware of this issue on your end as well?

arthurian commented 8 years ago

Closing this issue because it should be fixed in the the admin_hub_v2 branch by commit 3021209debf3199907a23a8270c04459c54eb3d9