remove pixels and demo from fish builtins. make it harder to shoot self in foot

Harvard-PRINCESS / Guppy

A very adaptable fish.

Other

1 stars 3 forks source link

remove pixels and demo from fish builtins. make it harder to shoot self in foot #61

Open mwookawa opened 7 years ago

mwookawa commented 7 years ago

onesself in the foot with the terminal

penlu commented 7 years ago

this also cleans up a couple of things in the shell
builds+boots on armv7/FVP and x86_64/QEMU, fish runs (as well as it ever has for me) note that sometimes "execution successful" messages come back a little out of order:

oncore 0 /x86_64/sbin/examples/xmpl-hello /x86_64/sbin/examples/xmpl-hello: file not found: The given name does not exist oncore 0 /x86_64/sbin/examples/xmpl-helloexecution successful with domain id: (null) /x86_64/sbin/examples/xmpl-hello: file not found: The given name does not exist

seems essentially cosmetic to me?

jingmeihu commented 7 years ago

build and boot are fine, but when I run hello world example, there are some page faults. (both qemu and pandaboard have the same problem).

oncore 0 /x86_64/sbin/examples/xmpl-hello
spawnd.0.0: spawning /x86_64/sbin/examples/xmpl-hello on core 0
kernel 0: user page fault in 'fish': addr b IP 5f2a4a SP 980330 error 0x4
Can't deliver exception to thread: handler not set
fish: unhandled page fault (error code 0x4) on b at IP 5f2a4a
kernel_dump_ptables

mwookawa commented 7 years ago

spawn doesn't seem to pass back a correct domain_id. this was a latent bug in the barrelfish trunk. i'll take a quick look at the spawn function to see if it's easy to trace this back to domain id assignment (or if it's deprecated or ??), and if it's not, i'll use the same workaround.