Harvest-Dev / ng-walkthrough

A walkthrough for Angular
MIT License
21 stars 8 forks source link

Problem with multiple Walkthrough on different pages #30

Open IvanLencina opened 5 years ago

IvanLencina commented 5 years ago

Hello, I have an Ionic 4 app that is using that dependency.

The walkthrough was working fine. But now, we need to use the walkthrough in different pages and we have an error. When we call this.walkFlow.start() in the first, and second pages, it works. Then in the third page is no longer appearing.

And we get that warning: image (4)

Do you know how to stop the previous walkthrough? I thought that it is because of a component lifecycle problem, but it doesn't because if I reload the page (the same page) it appears.

IvanLencina commented 5 years ago

I realize that, after navigating to the next page, the walkthrough is attempting to show the last step of the flow of the last page. Is not refreshing and does not try to show the new one.

I think that is because it renders the <walkthrough-container> inside the body tag.

Cannot we set inside which tag we want to render it? For example inside each angular component.

or else, you could implement that when you click on the "finish" button in the last step of each flow, the component would be removed from the body tag so, a new one will be generated again when calling it on another page.