search

HarvestStat / HarvestStat

HarvestStat - Harmonized Subnational Crop Statistics
MIT License
8 stars 5 forks source link

Full update #32

Closed WestonAnderson closed 7 months ago

WestonAnderson commented 7 months ago

Major updates to new format, scripts added

WestonAnderson commented 7 months ago

Hi Donghoon,

Sounds good, I made those changes. Should I cancel the original pull request and open a new one? Or do I just create a new one on-top of the old one?

Best, Weston

On Mon, Feb 26, 2024 at 12:38 PM Donghoon Lee @.***> wrote:

@.**** requested changes on this pull request.

Hi Weston, see my comments below:

  1. Exclude yld_detrend figures
  2. We decided to keep validation notebooks in two channels (1 and 2). So please rename your validation notebooks to xxx_Validation2.ipynb, especially for AO, LS, MG, MW, MZ, ZA. I cannot rename them in my side.

— Reply to this email directly, view it on GitHub https://github.com/chc-ucsb/HarvestStat/pull/32#pullrequestreview-1901597670, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACETCHHZ5LYJL5D22EEBF5LYVTCBJAVCNFSM6AAAAABDXMPDXSVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTSMBRGU4TONRXGA . You are receiving this because you authored the thread.Message ID: @.***>

gnodnooh commented 7 months ago

Hi Donghoon, Sounds good, I made those changes. Should I cancel the original pull request and open a new one? Or do I just create a new one on-top of the old one? Best, Weston … On Mon, Feb 26, 2024 at 12:38 PM Donghoon Lee @.> wrote: @*.*** requested changes on this pull request. Hi Weston, see my comments below: 1. Exclude yld_detrend figures 2. We decided to keep validation notebooks in two channels (1 and 2). So please rename your validation notebooks to xxx_Validation2.ipynb, especially for AO, LS, MG, MW, MZ, ZA. I cannot rename them in my side. — Reply to this email directly, view it on GitHub <#32 (review)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACETCHHZ5LYJL5D22EEBF5LYVTCBJAVCNFSM6AAAAABDXMPDXSVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTSMBRGU4TONRXGA . You are receiving this because you authored the thread.Message ID: @.>

You can commit&push then update your existing PR.

WestonAnderson commented 7 months ago

Okay, the pull request should be updated. Take a look and let me know what you think