search

Harvey-OS / ninep

Package for implementing clients and servers of the 9P and 9P2000 distributed resource protocols in Go.
Other
39 stars 19 forks source link

filesystem: return an array of QIDS one longer than the last successful walk #16

Closed rminnich closed 8 years ago

rminnich commented 8 years ago

For as long as I've been writing 9p servers (20 years now, oh joy) I thought a walk that ended in an error should only return the number of QIDs successfully walked. Oops. It needs to return one more, the last one being invalid; unless the number is zero, in which case it should return error and no QIDS.

This fixes an error message printing problem seen in harvey.

So far, the score is harvey 3, Go servers 0, when it comes to correctness in 9p :-) This server has had two errors so far, found in simple ls commands.

Signed-off-by: Ronald G. Minnich rminnich@gmail.com

harveybot commented 8 years ago

Please review this @hagna and @sevki

hdonnay commented 8 years ago

LGTM

Approved with PullApprove