search

Harvey-OS / ninep

Package for implementing clients and servers of the 9P and 9P2000 distributed resource protocols in Go.
Other
39 stars 19 forks source link

Cpuprofile #7

Closed hagna closed 8 years ago

hagna commented 8 years ago

You do ufs -cpuprofile A and you get files labelled A127.0.0.1:43306 etc.

harveybot commented 8 years ago

Please review this @rminnich and @sevki

rminnich commented 8 years ago

-1 There's a couple problems here. It's too broad a PR -- you bundle in changing import, with adding profile, with some other stuff.

You need a PR to fix the imports first.

To set up profiling, consider: add a Profiling member to stub.Server adding a "serverprofiling" flag in stub.go, - in server.go, you can test that flag in NewServer, and, if set, enable profiling use runtime.SetFinalizer to output the info when that server ends.

Rejected with PullApprove

rminnich commented 8 years ago

So:

do not commit