Serverprofile - Githubissues

Harvey-OS / ninep

Package for implementing clients and servers of the 9P and 9P2000 distributed resource protocols in Go.

Other

39 stars 19 forks source link

Serverprofile #9

Closed hagna closed 8 years ago

hagna commented 8 years ago

This adds the serverprofile option.

endSrvProfile could also be called from a finalizer for Server if you want.

harveybot commented 8 years ago

Please review this @rminnich and @sevki

rminnich commented 8 years ago

I'm lost -- when did the finalizer get added? I better get back up to speed with ninep :-)

you didn't add that trace change I hope from the earlier PR.

rminnich commented 8 years ago

See my note on user of defer, but this is close. Thanks.

rminnich commented 8 years ago

The main reason for return in this case is that are done and want to make sure nothing else happens. The only reason for a break would be to do exit processing, but you've covered that with the defer. The combination of return and defer is a lot more reliable than break and exit processing.

I think you need to gofmt -w this file and then we're good to go. Thanks.

rminnich commented 8 years ago

LGTM