search

HarveyD / react-component-library

A project skeleton to get your very own React Component Library up and running using Rollup, Typescript, SASS + Storybook
https://blog.harveydelaney.com/creating-your-own-react-component-library/
MIT License
786 stars 167 forks source link

[QUESTION] rollup-plugin-postcss plugin issues on code splitting #24

Open mnlbox opened 4 years ago

mnlbox commented 4 years ago

Hi @HarveyD , Now I have to use both rollup-plugin-postcss and rollup-plugin-sass because of your guide in ReadMe because I need code splitting and a single bundle. What is your suggestion if I want just using one of these package rollup-plugin-postcss or rollup-plugin-sass? I see in the ReadMe you told:

Please note, there's an issue with code splitting and using rollup-plugin-postcss. I recommend using rollup-plugin-sass instead alongside code splitting.

Can you explain what is this issue exactly? Maybe we can find a solution for that. :wink:

mnlbox commented 4 years ago

Maybe we can use https://github.com/Anidetrix/rollup-plugin-styles for both single bundle and multi bundle. I think using the same package for both branches is better approach :wink: