search

HarveyHunt / howm

A lightweight, X11 tiling window manager that behaves like vim
GNU General Public License v2.0
651 stars 24 forks source link

Feature/cut paste #19

Closed HarveyHunt closed 10 years ago

HarveyHunt commented 10 years ago

This isn't ready to merge right now, but it'd be great to see if people can track down bugs.

I still need to implement workspace support, that should be trivial though.

I am pretty sure that there is a bug when cutting a client (or group of clients) from between other clients and then pasting them in- let me know if you have this problem.

anubhavcodes commented 10 years ago

I cannot reproduce the bug that you mention! merge it.

HarveyHunt commented 10 years ago

I can still reproduce the bug. Open two terminals, select that last one and press "dc" The first client won't be rearranged until you click it.

I am almost certain this is caused by update_focuse_client being given the wrong client (line 2498 of my latest commit).

anubhavcodes commented 10 years ago

The bug that you commented was reproduced last night on arch linux. Now I built the same code on ubuntu and something wierd is happening on my side. If I cut the second terminal, changed the workspace, and hit paste, the cut that was cut is not respawned on the workspace that I am trying to paste on, instead it will get post on the same workspace on which it was on before.

I will try to understand what's going on op_cut and op_paste.

Edit: There seems to be a lot of bugs. Cutting some clients and opening a new workspace will paste them automatically on earlier client.

I think somethings wrong with the change_ws function, which will ultimately come down to update_focused_client function. So yes I agree with you

EDIT 2: The bugs that I am talking about can't be reproduced on a xephyr sessoin (Yes I managed to start a xephyr session on ubuntu) But the remaining client won't resize on a cut bug still remains.

HarveyHunt commented 10 years ago

This is basically ready to merge (I'll have to do it by hand). I know that there are bugs that occur when cnt is greater than the number of clients. I can't really fix that until #20 is done.

Neo- want to give #20 a go?

anubhavcodes commented 10 years ago

Okay merge this, weekend is here, so yes we can dive right into bug hunting!! :) We will take a look into it soon.