search

HarveyHunt / howm

A lightweight, X11 tiling window manager that behaves like vim
GNU General Public License v2.0
649 stars 24 forks source link

Removed trailing whitespaces and corrected typos. #4

Closed vimeitor closed 9 years ago

vimeitor commented 9 years ago

No need to merge this yet. I will spend a little bit more time correcting stuff, and will let you know when it's ready.

EDIT: I will drop this PR and send a new one. I forgot to work on it on a new branch and now it's giving me problems when rebasing.

HarveyHunt commented 9 years ago

This looks good- when you send me a new PR I will merge this right away. Thanks!

vimeitor commented 9 years ago

You can definitely merge this if you want, but I've found some other errors which I will eventually correct. Unfortunately, I messed up my local repo when trying to rebase, so I will need to manually extract the commits and apply and rebase them in another branch. I will let you know :).

HarveyHunt commented 9 years ago

The repo to merge this PR from is gone. I'll just wait for you to finish fixing your local repo and then send me a new PR. I don't want to merge this using diffs, as then you won't be on the contributors list on Github.

vimeitor commented 9 years ago

You can go ahead and get the patch :). Don't worry about that author thing; it's a very small pull request, anyway, so it's not a big deal at all. Actually, I think if you add a ".patch" at the end of the URL, you will get a diff that keeps the author of the commit. The pull request that I was planning on doing was a pretty large one, with quite a lot of changes, but I don't want to be a grammar nazi, so I will most likely drop it. By the way, it's a good idea to keep the first line of each commit message under 75 characters so that git log and github display them correctly (vim, for example, will warn you when you go over that). I guess it doesn't matter that much.

HarveyHunt commented 9 years ago

Thanks for the tip about .patch- I didn't know that.

I more than welcome you being a grammar nazi- I usually am but have written the docs at all sorts of weird times and states of sleep, docs are the first to suffer when I am tired.

I didn't realise about that (I use smartgithg to handle my git things), I'll remember that for future- thanks.

vimeitor commented 9 years ago

You can also add ".diff" if you don't want the author and other stuff :). Oh, and thank you for creating and maintaining howm. I'm sure everyone appreciates your effort as much as I do.

HarveyHunt commented 9 years ago

Thanks vimeitor, these are useful tips you're giving me.

I'm sorry that I didn't include you name in the commit, I fucked up merging the patch.

Don't worry, I have been enjoying it, learnt a lot and like giving back to the community. :-)