search

HarveyHunt / i3situation

A replacement for i3status written in Python 3 with support for huge customisability through plugins.
GNU General Public License v3.0
34 stars 5 forks source link

Fix typo in username #4

Closed wei2912 closed 10 years ago

wei2912 commented 10 years ago

Sorry for not creating another branch; I forgot about that.

wei2912 commented 10 years ago

This commit is inside https://github.com/HarveyHunt/i3situation/pull/5 so I'll be closing this one.

HarveyHunt commented 10 years ago

Merging this seperately.

HarveyHunt commented 10 years ago

PR looks good, I have merged the typo fix seperately to get that straight into master.

Please may you reduce this PR to just the reddit change, change max-chars to max_chars (as per my comment above) and add some docs for the new option. Please may you also target this at the develop branch?

Thanks for the PR, will merge once the above is done. :+1:

wei2912 commented 10 years ago

Sure, I'll do it the next time I'm on my desktop.

Sorry for the inconvenience, I was half-awake when I was writing that. On 24 Jun, 2014 1:03 am, "HarveyHunt" notifications@github.com wrote:

PR looks good, I have merged the typo fix seperately to get that straight into master.

Please may you reduce this PR to just the reddit change, change max-chars to max_chars (as per my comment above) and add some docs for the new option. Please may you also target this at the develop branch?

Thanks for the PR, will merge once the above is done. [image: :+1:]

— Reply to this email directly or view it on GitHub https://github.com/HarveyHunt/i3situation/pull/4#issuecomment-46872482.

HarveyHunt commented 10 years ago

No inconvenience at all- once again thanks for the PR. My above comment was on the wrong PR, I am sure you get what I meant though. :)