Add support to Reddit plugin for setting a limit to the number of characters of a title

HarveyHunt / i3situation

A replacement for i3status written in Python 3 with support for huge customisability through plugins.

GNU General Public License v3.0

34 stars 5 forks source link

Add support to Reddit plugin for setting a limit to the number of characters of a title #5

Closed wei2912 closed 10 years ago

wei2912 commented 10 years ago

This helps to prevent overflowing the panel/bar.

wei2912 commented 10 years ago

Unfortunately the previous commit is linked in with https://github.com/HarveyHunt/i3situation/pull/4 so you might want to directly merge this one in.

HarveyHunt commented 10 years ago

Commented on the wrong PR, long day!

PR looks good, I have merged the typo fix seperately to get that straight into master.

Please may you reduce this PR to just the reddit change, change max-chars to max_chars (as per my comment above) and add some docs for the new option. Please may you also target this at the develop branch?

Thanks for the PR, will merge once the above is done. :+1:

wei2912 commented 10 years ago

I was too lazy to do rebasing, so I've made the change in another branch.

Closing this one, refer to https://github.com/HarveyHunt/i3situation/pull/7